From 6d606f37f6530bfb208fdc2605f5dd73a61a7004 Mon Sep 17 00:00:00 2001
From: Markus Hilger <markus.hilger@megware.com>
Date: Mon, 13 Jul 2026 05:29:49 +0200
Subject: [PATCH] Fix Shellcheck errors

Fix SC2045 (error): Iterating over ls output is fragile. Use globs.

Add exception SC2068 exception for confluent_client/confluent_env.sh as this is intended.
SC2068 (error): Double quote array expansions to avoid re-splitting elements.
---
 confluent_client/confluent_env.sh                           | 2 ++
 confluent_osdeploy/debian/profiles/default/scripts/pre.sh   | 6 +++---
 .../ubuntu18.04/profiles/default/scripts/pre.sh             | 6 +++---
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/confluent_client/confluent_env.sh b/confluent_client/confluent_env.sh
index 1fa7be3a..84482cde 100644
--- a/confluent_client/confluent_env.sh
+++ b/confluent_client/confluent_env.sh
@@ -53,6 +53,8 @@ _confluent_get_args()
         CMPARGS+=("")
     fi
     GENNED=""
+    # Whitespace separates candidate groups, while commas group synonyms.
+    # shellcheck disable=SC2068
     for CAND in ${COMP_CANDIDATES[@]}; do
         candarray=(${CAND//,/ })
         matched=0
diff --git a/confluent_osdeploy/debian/profiles/default/scripts/pre.sh b/confluent_osdeploy/debian/profiles/default/scripts/pre.sh
index f30d81bb..71e758f7 100755
--- a/confluent_osdeploy/debian/profiles/default/scripts/pre.sh
+++ b/confluent_osdeploy/debian/profiles/default/scripts/pre.sh
@@ -34,8 +34,8 @@ done
 if [ -e /tmp/installdisk ]; then
     instdisk=$(cat /tmp/installdisk)
 else
-    for blockdev in $(ls /sys/class/block/); do
-        shortname=$(basename $blockdev)
+    for blockdev in /sys/class/block/*; do
+        shortname=$(basename "$blockdev")
         if [ "$shortname" != "${shortname%loop*}" ]; then
             continue
         fi
@@ -62,7 +62,7 @@ else
     done
 fi
 if [ -z "$instdisk" ]; then
-    if [ ! -z "$sraid"]; then
+    if [ ! -z "$sraid" ]; then
         instdisk=$sraid
     elif [ ! -z "$onbdisk" ]; then
         instdisk=$onbdisk
diff --git a/confluent_osdeploy/ubuntu18.04/profiles/default/scripts/pre.sh b/confluent_osdeploy/ubuntu18.04/profiles/default/scripts/pre.sh
index 10d4d630..546e1769 100755
--- a/confluent_osdeploy/ubuntu18.04/profiles/default/scripts/pre.sh
+++ b/confluent_osdeploy/ubuntu18.04/profiles/default/scripts/pre.sh
@@ -34,8 +34,8 @@ done
 if [ -e /tmp/installdisk ]; then
     instdisk=$(cat /tmp/installdisk)
 else
-    for blockdev in $(ls /sys/class/block/); do
-        shortname=$(basename $blockdev)
+    for blockdev in /sys/class/block/*; do
+        shortname=$(basename "$blockdev")
         if [ "$shortname" != "${shortname%loop*}" ]; then
             continue
         fi
@@ -62,7 +62,7 @@ else
     done
 fi
 if [ -z "$instdisk" ]; then
-    if [ ! -z "$sraid"]; then
+    if [ ! -z "$sraid" ]; then
         instdisk=$sraid
     elif [ ! -z "$onbdisk" ]; then
         instdisk=$onbdisk