2
0
mirror of https://github.com/xcat2/confluent.git synced 2024-11-21 17:11:58 +00:00

Remove single byte TLV concept from socket protocol.

For local socket, it isn't enough to matter.  In network protocols, encryption
will generally cause things to be rounded up to the next 16 bytes anyway.

Make things simpler implementation wise by sticking to 4 byte tl bytes,
but still reserve TL with hi bit set, just in case.
This commit is contained in:
Jarrod Johnson 2013-10-12 21:15:52 -04:00
parent 53ce6f054c
commit 6a79a30fc0

View File

@ -4,19 +4,15 @@ the socket protocol is empowered to do whatever is needed.
All data across the wire is TLV values.
(since a single character is an exceedingly common case, have a single byte TLV
for those occasions)
Single byte TL (msb: 0):
Type=0
Length=TL & 0b01111111
Types:
0: text string
A shorter single byte TLV variant was considered for lower overhead for things
like single character, but in every case where throughput efficiency would
matter is probably padded to 16 byte boundaries anyway due to block ciphers.
(all other data has a 4 byte TLV for now)
Four byte TLs: (msb: 0b10)
Type=TL & 0b00111111000000000000000000000000 >> 24:
(all data has a 4 byte TLV for now)
Four byte TLs: (msb: 0b0)
Type=TL & 0b01111111000000000000000000000000 >> 24:
Length= TL & 0b111111111111111111111111
0: text string
1: json data
(msb: 0b11 is reserved), probably never to be needed
(msb: 0b1 is reserved), probably never to be needed