From 5f1ba49a126c2cc9f0d05204dc9d9f86dd908ca2 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Wed, 22 Jul 2020 13:56:55 -0400 Subject: [PATCH] Fix behavior with unspecified domain name Ensure string is only checked if it is a string. --- confluent_server/confluent/selfservice.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/confluent_server/confluent/selfservice.py b/confluent_server/confluent/selfservice.py index f565cab0..81a8f6b4 100644 --- a/confluent_server/confluent/selfservice.py +++ b/confluent_server/confluent/selfservice.py @@ -155,7 +155,7 @@ def handle_request(env, start_response): dnsinfo = cfg.get_node_attributes(nodename, ('dns.*')) dnsinfo = dnsinfo.get(nodename, {}).get('dns.domain', {}).get('value', None) - if dnsinfo in nodename: + if dnsinfo and dnsinfo in nodename: dnsinfo = '' cert = sshutil.sign_host_key(reqbody, nodename, [dnsinfo]) start_response('200 OK', (('Content-Type', 'text/plain'),))