Revert "Accommodate XCC firmware behavior"

This reverts commit 9baa1f5652.

confluent_server/confluent/discovery/core.py

@@ -823,12 +823,7 @@ def eval_node(cfg, handler, info, nodename, manual=False):
         handler.probe()  # unicast interrogation as possible to get more data
         # switch concurrently
         # do some preconfig, for example, to bring a SMM online if applicable
-        errorstr = handler.preconfig()
-        if errorstr:
-            if manual:
-                raise exc.InvalidArgumentException(errorstr)
-            log.log({'error': errorstr})
-            return
+        handler.preconfig()
     except Exception as e:
         unknown_info[info['hwaddr']] = info
         info['discostatus'] = 'unidentified'

confluent_server/confluent/discovery/handlers/xcc.py

@@ -22,24 +22,7 @@ class NodeHandler(immhandler.NodeHandler):
     devname = 'XCC'
 
     def preconfig(self):
-        ff = None
-        try:
-            ff = self.info['attributes']['enclosure-form-factor']
-        except KeyError:
-            try:
-                # an XCC should always have that set, this is sign of
-                # a bug, try to reset the BMC as a workaround
-                ipmicmd = self._get_ipmicmd()
-                ipmicmd.reset_bmc()
-                return "XCC with address {0} did not have attributes " \
-                       "declared, attempting to correct with " \
-                       "XCC reset".format(self.ipaddr)
-            except pygexc.IpmiException as e:
-                if (e.ipmicode != 193 and
-                        'Unauthorized name' not in str(e) and
-                        'Incorrect password' not in str(e)):
-                # raise an issue if anything other than to be expected
-                raise
+        ff = self.info.get('attributes', {}).get('enclosure-form-factor', '')
         if ff not in ('dense-computing', [u'dense-computing']):
             return
         # attempt to enable SMM