Follow-up of #860 and #791 to fix:
File "./zaza/openstack/charm_tests/test_utils.py", line 798, in launch_guest
return configure_guest.launch_instance(
File "./zaza/openstack/configure/guest.py", line 128, in launch_instance
image_name = image_name or boot_tests[instance_key]['image_name']
KeyError: 'jammy'
I recently added an option to have zaza delete and relaunch a
guest if it failed to be provisioned or failed a connectivity
test. However, in the code to remove the an instance I
accidentaly called the method that checks that a resource has
gone and not the method that actually does the removal. This
patch fixes that. NOTE: Only the Trilio tests use this
retryer function atm
Add a method called launch_instance_retryer which will attempt
to launch an instance. In the event that it fails the instance
will be removed and another attempt to launch an instance will
be attempted.
Allow launching an instance and attaching it directly to the
external provider network. This is useful in its own right and
is also a requirement in order to successfully test some
configurations.
It's a bit too optimistic to expect an instance to respond to the first
ping. This patch gives the instance up to 8 retries with increasingly
lengthened waits to respond to a ping. This should help with Juju
storage backed nova instances.
Fixes: #265