From ca97fc184d7a02353bd806e8f4fffa25a6a69948 Mon Sep 17 00:00:00 2001
From: jbjohnso <jbjohnso@8638fb3e-16cb-4fca-ae20-7b5d299a9bcd>
Date: Fri, 18 Jul 2008 18:40:45 +0000
Subject: [PATCH] -Fix dhcp plugin compliance with perl strict

git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@1896 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
---
 xCAT-server/lib/xcat/plugins/dhcp.pm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/xCAT-server/lib/xcat/plugins/dhcp.pm b/xCAT-server/lib/xcat/plugins/dhcp.pm
index 35a7c9994..223500bd2 100644
--- a/xCAT-server/lib/xcat/plugins/dhcp.pm
+++ b/xCAT-server/lib/xcat/plugins/dhcp.pm
@@ -1,5 +1,6 @@
 # IBM(c) 2007 EPL license http://www.eclipse.org/legal/epl-v10.html
 package xCAT_plugin::dhcp;
+use strict;
 use xCAT::Table;
 use Data::Dumper;
 use MIME::Base64;
@@ -31,6 +32,7 @@ sub delnode
     my $inetn = inet_aton($node);
 
     my $mactab = xCAT::Table->new('mac');
+    my $ent;
     if ($mactab) { $ent = $mactab->getNodeAttribs($node, [qw(mac)]); }
     if ($ent and $ent->{mac})
     {
@@ -269,7 +271,7 @@ sub preprocess_request
     }    #Exit if the packet has been preprocessed in its history
     my @requests =
       ({%$req});    #Start with a straight copy to reflect local instance
-    my @sn = xCAT::Utils->getSNList(dhcpserver);
+    my @sn = xCAT::Utils->getSNList('dhcpserver');
     foreach my $s (@sn)
     {
         my $reqcopy = {%$req};
@@ -362,6 +364,7 @@ sub process_request
     }
     else
     {
+        my $rconf;
         open($rconf, "/etc/dhcpd.conf");    # Read file into memory
         if ($rconf)
         {
@@ -712,7 +715,7 @@ sub newconfig
     push @dhcpconf, "key xcat_key {\n";
     push @dhcpconf, "  algorithm hmac-md5;\n";
     (my $passent) =
-      $passtab->getAttribs({key => omapi, username => 'xcat_key'}, 'password');
+      $passtab->getAttribs({key => 'omapi', username => 'xcat_key'}, 'password');
     my $secret = encode_base64(genpassword(32));    #Random from set of  62^32
     chomp $secret;
     if ($passent->{password}) { $secret = $passent->{password}; }
@@ -724,7 +727,7 @@ sub newconfig
                 ["The dhcp server must be restarted for OMAPI function to work"]
              }
              );
-        $passtab->setAttribs({key => omapi},
+        $passtab->setAttribs({key => 'omapi'},
                              {username => 'xcat_key', password => $secret});
     }