From c5f12144692baae0ea7ec46be510653fefb6f9f8 Mon Sep 17 00:00:00 2001 From: lissav Date: Sat, 8 Sep 2012 10:11:32 +0000 Subject: [PATCH] Take out bad host processing until redesign to get rid of inf loop in getdata git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@13727 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd --- xCAT-server/lib/xcat/plugins/updatenode.pm | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/xCAT-server/lib/xcat/plugins/updatenode.pm b/xCAT-server/lib/xcat/plugins/updatenode.pm index 4fa6c32a8..c2ec4fa81 100644 --- a/xCAT-server/lib/xcat/plugins/updatenode.pm +++ b/xCAT-server/lib/xcat/plugins/updatenode.pm @@ -567,16 +567,18 @@ sub preprocess_updatenode my @tmp_a = split(',', $snkey); foreach my $s1 (@tmp_a) { - if ( $::SECURITY - && !(grep /^$s1$/, @::good_sns) # is it good - && !(grep /^$s1$/, @MNip)) # is the MN - { - my $rsp; - push @{$rsp->{data}}, - "The security update for service node $snkey encountered error, update security for following nodes will be skipped: @{$sn->{$snkey}}"; - xCAT::MsgUtils->message("E", $rsp, $callback); - next; - } + # TODO fix the error handling, right now cause inf loop + # when getdata and updatenode_cb are registered LKV + # if ( $::SECURITY + # && !(grep /^$s1$/, @::good_sns) # is it good + # && !(grep /^$s1$/, @MNip)) # is the MN + # { + # my $rsp; + # push @{$rsp->{data}}, + # "The security update for service node $snkey encountered error, update security for following nodes will be skipped: @{$sn->{$snkey}}"; + # xCAT::MsgUtils->message("E", $rsp, $callback); + # next; + # } # remove the service node which have been handled before #if ($::SECURITY && (grep /^$s1$/, @MNip))