From c2f1d848ff2c46151ff358935800a9a52ddaa499 Mon Sep 17 00:00:00 2001 From: jjhua Date: Wed, 2 May 2012 06:09:39 +0000 Subject: [PATCH] add some comments git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/branches/2.7@12450 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd --- perl-xCAT/xCAT/FSPUtils.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/perl-xCAT/xCAT/FSPUtils.pm b/perl-xCAT/xCAT/FSPUtils.pm index cfd3d47d8..36ccb9e3a 100644 --- a/perl-xCAT/xCAT/FSPUtils.pm +++ b/perl-xCAT/xCAT/FSPUtils.pm @@ -160,7 +160,7 @@ sub getIPaddress #my $tmp_s = $vpdtab->getNodeAttribs($nodetocheck, ['side']); my $tmp_s = $vpd->{$nodetocheck}; if ($tmp_s and $tmp_s =~ /(A|B)-\d/i) { - $side = $1; # get side for the fsp, in order to get its brothers + $side = $1; # get side for the fsp } else { return -3; @@ -172,6 +172,7 @@ sub getIPaddress } if( @children == 0 ) { if( exists($ppc->{$parent} ) ) { + #for cec/frame, get the FSPs/BPAs from the hash we built in getHcpAttribs() before. @children = @{$ppc->{$parent}->{children}}; } else { return undef; @@ -315,7 +316,8 @@ sub fsp_api_action { #print "fsp name: $fsp_name\n"; #print "fsp ip: $fsp_ip\n"; - #get the HMC/password from passwd table or ppcdirect table. + #In DFM, only the add_connection action need the userid/password to create the connection + #between hdwr_svr and FSPs or BPAs. if( $action =~ /^add_connection$/) { my $tmp_node; if( $$attrs[4] =~ /^cec$/ || $$attrs[4] =~ /^frame$/ ) { @@ -333,7 +335,7 @@ sub fsp_api_action { $res = "Cannot get password of userid 'HMC'. Please check table 'passwd' or 'ppcdirect'."; return ([$node_name, $res, -1]); } - + # The userid for creating connection only is "HMC". $user = 'HMC'; }