From 6c6f16a8f5faa249ed0898bb47db5b523d740081 Mon Sep 17 00:00:00 2001
From: jbjohnso <jbjohnso@8638fb3e-16cb-4fca-ae20-7b5d299a9bcd>
Date: Mon, 24 Jun 2013 19:17:16 +0000
Subject: [PATCH] Rework sshnode sub to avoid pasing glob by reference since
 some perls don't seem to like that

git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@16736 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
---
 xCAT-client/bin/psh | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/xCAT-client/bin/psh b/xCAT-client/bin/psh
index bdb1db4e1..057ca7929 100755
--- a/xCAT-client/bin/psh
+++ b/xCAT-client/bin/psh
@@ -127,11 +127,8 @@ if ($timeout) { alarm($timeout); }
 foreach (@nodes) {
   my $node=$_;
   while ($children >= $pshmaxp) { processoutput($inputs); }
-  my $child;
   $children++;
-  sshnode(\$child,$node,$username,@ARGV[1 .. $#ARGV]);
-  $inputs->add($child);
-  $nodehdl{$child} = $node;
+  sshnode($inputs,\%nodehdl,$node,$username,@ARGV[1 .. $#ARGV]);
 }
 while ($inputs->count) {
   processoutput($inputs);
@@ -187,14 +184,18 @@ sub processoutput { #This way, one arbiter handles output, no interrupting
   return $rc;
 }
 sub sshnode {
-  my $out = shift;
+  my $inputs = shift;
+  my $nodehdl = shift;
   my $node = shift;
   my $username = shift;
+  my $out;
   if (length($username)) { $username = "-l $username"; }
   my $in;
   my $args = join(" ",@_);
   #print "ssh -o BatchMode=yes $username $node " . xCAT::Utils->quote($args) . " 2>&1 |\n";
-  my $pid = open($$out,"ssh -o BatchMode=yes $username $node " . xCAT::Utils->quote($args) . " 2>&1 |");
+  my $pid = open($out,"ssh -o BatchMode=yes $username $node " . xCAT::Utils->quote($args) . " 2>&1 |");
+  $inputs->add($out);
+  $nodehdl->{$out} = $node;
   $pids{$pid} = $node;
 }