From 1e59b83e1d8eb53f413072e98674c9060c71fe97 Mon Sep 17 00:00:00 2001
From: zhaoertao <zhaoertao@8638fb3e-16cb-4fca-ae20-7b5d299a9bcd>
Date: Tue, 7 May 2013 10:53:32 +0000
Subject: [PATCH] fix bug 3552, using mp.id and ipmi.bmc to judge whether it is
 a x blade.

git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@16210 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
---
 xCAT-server/lib/xcat/plugins/blade.pm | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/xCAT-server/lib/xcat/plugins/blade.pm b/xCAT-server/lib/xcat/plugins/blade.pm
index f163cab31..d13451bf5 100644
--- a/xCAT-server/lib/xcat/plugins/blade.pm
+++ b/xCAT-server/lib/xcat/plugins/blade.pm
@@ -4663,7 +4663,7 @@ sub clicmds {
         }
         verbose_message("start update password for all BMCs.");
         my $start = Time::HiRes::gettimeofday();
-        updateBMC($mpa,$user,$promote_pass);
+        updateBMC($mpa,$user,$handled{USERID});
         verbose_message("Finish update password for all BMCs.");
         my $slp = Time::HiRes::gettimeofday() - $start;
         my $msg = sprintf("The main process time slp: %.3f sec", $slp);
@@ -4897,18 +4897,26 @@ sub updateBMC {
     my $mpa = shift;
     my $user = shift;
     my $pass = shift;
+    my @nodes = ();
     my $mptab = xCAT::Table->new('mp');
-    my $nttab = xCAT::Table->new('nodetype');
     if ($mptab) {
         my @mpents = $mptab->getAllNodeAttribs(['node','mpa','id']);
         foreach (@mpents) {
             my $node = $_->{node};
-            my $nodetype = $nttab->getNodeAttribs($node, ['nodetype']);
-            if ($_->{mpa} and ($_->{mpa} eq $mpa) and $_->{id} and defined($nodetype) and $nodetype->{nodetype} =~ /mp/)  {
-                xCAT::IMMUtils::setupIMM($node,skipbmcidcheck=>1,skipnetconfig=>1,cliusername=>$user,clipassword=>$pass,callback=>$CALLBACK);
+            if (defined($_->{mpa}) and ($_->{mpa} eq $mpa) and defined($_->{id}) and ($_->{id} ne '0')) {
+                push @nodes, $node;
             }
-        } 
-    } 
+        }
+    }
+    my $ipmitab = xCAT::Table->new('ipmi');
+    if ($ipmitab) {
+        my $ipmihash = $ipmitab->getNodesAttribs(\@nodes, ['bmc']);
+        foreach (@nodes) {
+            if (defined($ipmihash->{$_}->[0]) && defined ($ipmihash->{$_}->[0]->{'bmc'})) {
+                xCAT::IMMUtils::setupIMM($_,skipbmcidcheck=>1,skipnetconfig=>1,cliusername=>$user,clipassword=>$pass,callback=>$CALLBACK);
+            }  
+        }
+    }
     return ;
 }