arif/xcat-core
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-Table performance enhancements, makeconservercf, for example, a table set that induced a 10 second makeconservercf runtime is down to 3 seconds. (Now makeconservercf for this data set is an order of magnitude faster than 2.0, which was about 30 seconds for this test).

Browse Source 
git-svn-id: https://svn.code.sf.net/p/xcat/code/xcat-core/trunk@1850 8638fb3e-16cb-4fca-ae20-7b5d299a9bcd
This commit is contained in:
jbjohnso 2008-07-09 12:43:57 +00:00
parent dc45603115
commit 08f3fb3ac5
1 changed files with 44 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
perl-xCAT/xCAT/Table.pm
View File

@ -933,6 +933,13 @@ sub _build_cache { #PRIVATE FUNCTION, PLEASE DON'T CALL DIRECTLY
push @$attriblist,'node';
my @tabcache = $self->getAllAttribs(@$attriblist);
$self->{_tablecache} = \@tabcache;
$self->{_nodecache} = {};
if ($tabcache[0]->{node}) {
foreach(@tabcache) {
push @{$self->{_nodecache}->{$_->{node}}},$_;
}
}
$self->{_cachestamp} = time;
}
#--------------------------------------------------------------------------
@ -1571,27 +1578,45 @@ sub getAttribs
if ($self->{_use_cache}) {
my @results;
my $cacheline;
CACHELINE: foreach $cacheline (@{$self->{_tablecache}}) {
foreach (keys %keypairs) {
if (not $keypairs{$_} and $keypairs{$_} ne 0 and $cacheline->{$_}) {
next CACHELINE;
}
unless ($keypairs{$_} eq $cacheline->{$_}) {
next CACHELINE;
}
if (scalar(keys %keypairs) == 1 and $keypairs{node}) { #99.9% of queries look like this, optimized case
foreach $cacheline (@{$self->{_nodecache}->{$keypairs{node}}}) {
my $attrib;
my %rethash;
foreach $attrib (@attribs)
{
unless ($cacheline->{$attrib} =~ /^$/ || !defined($cacheline->{$attrib}))
{ #To undef fields in rows that may still be returned
$rethash{$attrib} = $cacheline->{$attrib};
}
}
if (keys %rethash)
{
push @results, \%rethash;
}
}
my $attrib;
my %rethash;
foreach $attrib (@attribs)
{
unless ($cacheline->{$attrib} =~ /^$/ || !defined($cacheline->{$attrib}))
{ #To undef fields in rows that may still be returned
$rethash{$attrib} = $cacheline->{$attrib};
} else { #SLOW WAY FOR GENERIC CASE
CACHELINE: foreach $cacheline (@{$self->{_tablecache}}) {
foreach (keys %keypairs) {
if (not $keypairs{$_} and $keypairs{$_} ne 0 and $cacheline->{$_}) {
next CACHELINE;
}
unless ($keypairs{$_} eq $cacheline->{$_}) {
next CACHELINE;
}
}
}
if (keys %rethash)
{
push @results, \%rethash;
my $attrib;
my %rethash;
foreach $attrib (@attribs)
{
unless ($cacheline->{$attrib} =~ /^$/ || !defined($cacheline->{$attrib}))
{ #To undef fields in rows that may still be returned
$rethash{$attrib} = $cacheline->{$attrib};
}
}
if (keys %rethash)
{
push @results, \%rethash;
}
}
}
if (@results)