From df37da0ff8a3fe52e8ba82f063a947320268c505 Mon Sep 17 00:00:00 2001 From: Wu-cheng Li Date: Thu, 23 Jul 2009 16:51:29 +0800 Subject: [PATCH 1/3] Correct the spelling of posterize. --- libcamera2/QualcommCameraHardware.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcamera2/QualcommCameraHardware.cpp b/libcamera2/QualcommCameraHardware.cpp index 2c820a1..3f808d4 100644 --- a/libcamera2/QualcommCameraHardware.cpp +++ b/libcamera2/QualcommCameraHardware.cpp @@ -178,7 +178,7 @@ static const str_map effect[] = { { "negative", CAMERA_EFFECT_NEGATIVE }, { "solarize", CAMERA_EFFECT_SOLARIZE }, { "sepia", CAMERA_EFFECT_SEPIA }, - { "postersize", CAMERA_EFFECT_POSTERIZE }, + { "posterize", CAMERA_EFFECT_POSTERIZE }, { "whiteboard", CAMERA_EFFECT_WHITEBOARD }, { "blackboard", CAMERA_EFFECT_BLACKBOARD }, { "aqua", CAMERA_EFFECT_AQUA }, From ca745bed48c8ab11c6a79c770e119f5f461df595 Mon Sep 17 00:00:00 2001 From: Chih-Chung Chang Date: Fri, 31 Jul 2009 11:28:01 +0800 Subject: [PATCH 2/3] Fix 2026448: Missing jpeg-quality parameter in donut. --- libcamera2/QualcommCameraHardware.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libcamera2/QualcommCameraHardware.cpp b/libcamera2/QualcommCameraHardware.cpp index 3f808d4..63d739a 100644 --- a/libcamera2/QualcommCameraHardware.cpp +++ b/libcamera2/QualcommCameraHardware.cpp @@ -264,6 +264,7 @@ void QualcommCameraHardware::initDefaultParameters() p.setPreviewFormat("yuv420sp"); // informative p.setPictureFormat("jpeg"); // informative + p.set("jpeg-quality", "100"); // maximum quality p.set("jpeg-thumbnail-width", THUMBNAIL_WIDTH_STR); // informative p.set("jpeg-thumbnail-height", THUMBNAIL_HEIGHT_STR); // informative p.set("jpeg-thumbnail-quality", "90"); From a4748564979cea756f8f72d43bf9536b10ebe2cc Mon Sep 17 00:00:00 2001 From: Wu-cheng Li Date: Fri, 31 Jul 2009 13:21:39 +0800 Subject: [PATCH 3/3] Remove antibanding because driver does not support them. --- libcamera2/QualcommCameraHardware.cpp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libcamera2/QualcommCameraHardware.cpp b/libcamera2/QualcommCameraHardware.cpp index 63d739a..981c46f 100644 --- a/libcamera2/QualcommCameraHardware.cpp +++ b/libcamera2/QualcommCameraHardware.cpp @@ -189,9 +189,6 @@ static char *effect_values; // from qcamera/common/camera.h static const str_map antibanding[] = { { "off", CAMERA_ANTIBANDING_OFF }, - { "60hz", CAMERA_ANTIBANDING_60HZ }, - { "50hz", CAMERA_ANTIBANDING_50HZ }, - { "auto", CAMERA_ANTIBANDING_AUTO }, { NULL, 0 } }; static char *antibanding_values; @@ -270,13 +267,7 @@ void QualcommCameraHardware::initDefaultParameters() p.set("jpeg-thumbnail-quality", "90"); p.setPictureSize(DEFAULT_PICTURE_WIDTH, DEFAULT_PICTURE_HEIGHT); - p.set("antibanding", - /* FIXME: - * CAMERA_ANTIBANDING_60HZ broke the barcode scanner somehow. turn it - * off and revert it back to off for now until we figure out what is - * the best solution. - */ - "off" /*"60hz" */); + p.set("antibanding", "off"); p.set("effect", "off"); p.set("whitebalance", "auto");